[codex] fix: preserve remainder rows across worker batches#11
Closed
sergioballesteros-vd wants to merge 1 commit into
Closed
[codex] fix: preserve remainder rows across worker batches#11sergioballesteros-vd wants to merge 1 commit into
sergioballesteros-vd wants to merge 1 commit into
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Author
|
Superseded by PR #12 with a cleaner branch/title. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes row loss in account and transaction generation when the requested totals do not divide evenly across
workers * batches_per_worker.The generator now splits work with exact shard planning, so every requested row is produced and no remainder is dropped.
Type of change
fix— bug fixtest— adding or updating testsLinked issues
Checklist
pytest tests/ -v --cov=gen_fraud_graph)ruff check . && black --check . && mypy src/)Notes for reviewers
The change is intentionally small and localized:
divmod-based helper